Skip to content

CNF-25667: Make e2e-aws-ci-tests optional for cnf-features-deploy 4.12–4.22 - #83849

Open
tavital wants to merge 1 commit into
openshift:mainfrom
tavital:make-optional-e2e-aws-ci-tests
Open

CNF-25667: Make e2e-aws-ci-tests optional for cnf-features-deploy 4.12–4.22#83849
tavital wants to merge 1 commit into
openshift:mainfrom
tavital:make-optional-e2e-aws-ci-tests

Conversation

@tavital

@tavital tavital commented Aug 22, 2026

Copy link
Copy Markdown

Mark the e2e-aws-ci-tests prow job optional so a failure no longer blocks PR merge.
The job still runs (and can be retriggered with /test or /retest) and reports status, but Tide ignores it when deciding whether to merge.

Summary by CodeRabbit

The PR updates cnf-features-deploy CI configurations for releases 4.12 through 4.22. It marks the e2e-aws-ci-tests Prow job as optional.

The job will continue to run and report its status. Its failures will not block PR merges.

@openshift-ci
openshift-ci Bot requested review from MarSik and Tal-or August 22, 2026 13:57
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f323374-b98a-4fd0-ac34-699168b96414

📥 Commits

Reviewing files that changed from the base of the PR and between 3361452 and fb9455b.

⛔ Files ignored due to path filters (11)
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.12-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.13-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.14-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.15-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.16-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.17-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.18-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.19-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.20-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.21-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.22-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (11)
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.12.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.13.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.14.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.15.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.16.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.17.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.18.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.19.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.20.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.21.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.22.yaml
🚧 Files skipped from review as they are similar to previous changes (11)
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.22.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.18.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.17.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.20.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.12.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.14.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.21.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.13.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.15.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.19.yaml
  • ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.16.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The CI operator configurations for CNF features deploy releases 4.12 through 4.22 now mark e2e-aws-ci-tests as optional.

Changes

CNF features deploy CI configuration

Layer / File(s) Summary
Mark AWS tests optional
ci-operator/config/openshift-kni/cnf-features-deploy/openshift-kni-cnf-features-deploy-release-4.*.yaml
Adds optional: true to the e2e-aws-ci-tests entry for releases 4.12 through 4.22.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to fb945

This change makes the e2e-aws-ci-tests job non-blocking for cnf-features-deploy 4.12–4.22 while keeping execution and status reporting unchanged; no actionable merge-blocking risk remains.

Suggested reviewers: marsik, tal-or

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes making e2e-aws-ci-tests optional for cnf-features-deploy releases 4.12 through 4.22.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (11 skipped: 11 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch adds only optional: true to 11 CI YAML job entries and changes no Ginkgo It, Describe, Context, or When test titles.
Test Structure And Quality ✅ Passed The PR changes only CI YAML metadata, adding optional:true to 11 test configs and 11 generated jobs; it adds no Ginkgo test code or cluster operations to assess.
Microshift Test Compatibility ✅ Passed The diff adds only optional: true to YAML CI configuration and generated job files; it adds no Ginkgo e2e tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only CI YAML to set e2e-aws-ci-tests optional; it adds no Ginkgo tests or test code with SNO multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only adds optional: true to CI test and generated Prow job entries; it adds no deployment, controller, or workload scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The HEAD diff contains only optional: true additions in 22 CI YAML files; no OTE source, stdout writes, or suite setup code changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit only adds optional: true to 11 test configs and 11 generated Prow jobs; it adds no Ginkgo tests or networking/external-connectivity code.
No-Weak-Crypto ✅ Passed The diff adds only optional: true to 22 YAML entries; it introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges ✅ Passed The diff adds only optional: true to 11 CI test records; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only optional: true to 11 test configs and 11 generated Prow jobs; it adds no logging code or sensitive values.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tavital tavital changed the title Make e2e-aws-ci-tests optional for cnf-features-deploy 4.12–4.22 CNF-25667: Make e2e-aws-ci-tests optional for cnf-features-deploy 4.12–4.22 Aug 22, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@tavital: This pull request references CNF-25667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Mark the e2e-aws-ci-tests prow job optional so a failure no longer blocks PR merge.
The job still runs (and can be retriggered with /test or /retest) and reports status, but Tide ignores it when deciding whether to merge.

Summary by CodeRabbit

The PR updates cnf-features-deploy release configurations for versions 4.12 through 4.22. It marks the e2e-aws-ci-tests Prow job as optional.

The job will continue to run and report status. Its failures will not block PR merges.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tavital

tavital commented Aug 22, 2026

Copy link
Copy Markdown
Author

/retest-required

Mark the e2e-aws-ci-tests prow job optional so a failure no longer blocks PR merge.
The job still runs (and can be retriggered with /test or /retest) and reports status, but Tide ignores it when deciding whether to merge.
Set optional: true on the e2e-aws-ci-tests test in the ci-operator/config/ files for release branches 4.12 through 4.22,
then ran make jobs to regenerate the corresponding Prow job configurations.

Signed-off-by: Tomer Avital <tavital@redhat.com>
@tavital
tavital force-pushed the make-optional-e2e-aws-ci-tests branch from 6c70d64 to fb9455b Compare August 22, 2026 14:46
@openshift-ci

openshift-ci Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tavital
Once this PR has been reviewed and has the lgtm label, please assign imiller0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@tavital: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-cnf-features-deploy-release-4.15-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.13-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.21-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.16-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.22-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.20-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.14-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.19-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.18-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.17-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
pull-ci-openshift-kni-cnf-features-deploy-release-4.12-e2e-aws-ci-tests openshift-kni/cnf-features-deploy presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@tavital

tavital commented Aug 22, 2026

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@tavital: This pull request references CNF-25667 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@tavital: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants